Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deleteField inside of an array #510

Merged
merged 25 commits into from
Dec 3, 2023
Merged

Fix deleteField inside of an array #510

merged 25 commits into from
Dec 3, 2023

Conversation

Christian24
Copy link
Contributor

This should fix deleting a field that is inside of an array. It should close #509

@codesandbox-ci CodeSandbox CI
Copy link

codesandbox-ci bot commented Nov 5, 2023 •
edited
Loading

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@Christian24 Christian24 mentioned this pull request Nov 5, 2023
Closed
@Christian24 Christian24 mentioned this pull request Nov 5, 2023
Closed
@crutchcorn
Copy link
Member

This now fixes #511 as well.

crutchcorn
crutchcorn approved these changes Dec 3, 2023
View reviewed changes
Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this! Thank you!

@codecov-commenter
Copy link

Codecov Report

Attention: 26 lines in your changes are missing coverage. Please review.

Comparison is base (c2f9957) 84.55% compared to head (b41b2ef) 91.65%.
Report is 56 commits behind head on main.

Files Patch % Lines
packages/form-core/src/FormApi.ts 89.55% 12 Missing and 2 partials ⚠️
packages/form-core/src/FieldApi.ts 92.85% 5 Missing ⚠️
packages/form-core/src/utils.ts 90.00% 2 Missing ⚠️
packages/react-form/src/useField.tsx 71.42% 2 Missing ⚠️
packages/solid-form/src/createField.tsx 96.55% 1 Missing ⚠️
packages/solid-form/src/createForm.tsx 92.30% 1 Missing ⚠️
packages/solid-form/src/formContext.ts 83.33% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   84.55%   91.65%   +7.09%     
==========================================
  Files           9       21      +12     
  Lines         395      671     +276     
  Branches      109      184      +75     
==========================================
+ Hits          334      615     +281     
+ Misses         52       49       -3     
+ Partials        9        7       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@crutchcorn crutchcorn merged commit 4e8bf2a into TanStack:main Dec 3, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crutchcorn crutchcorn crutchcorn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deleteField does not work inside if field is inside an array
3 participants
@Christian24 @crutchcorn @codecov-commenter